pnpm dedupe #25564
Merged
pnpm dedupe #25564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to pnpm-dedupe
github-actions
bot
added
area: build
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR performs dependency deduplication across packages using pnpm dedupe and updates Octokit dependencies to fix compilation errors that occurred after the deduplication process.
- Runs
pnpm dedupeacross all packages except the "server" release group (handled separately due to issues) - Updates @octokit/core from ^5.2.0 to ^7.0.4 and @octokit/rest from ^21.0.2 to ^22.0.0 to resolve compile errors
- Adds a new patch file for @microsoft/[email protected] to address validation and import emission issues
Reviewed Changes
Copilot reviewed 2 out of 12 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| server/routerlicious/patches/@[email protected] | New patch file fixing API extractor validation and import emission logic |
| build-tools/packages/build-cli/package.json | Updates Octokit dependencies to latest major versions |
Files not reviewed (10)
- build-tools/pnpm-lock.yaml: Language not supported
- common/build/eslint-config-fluid/pnpm-lock.yaml: Language not supported
- common/lib/common-utils/pnpm-lock.yaml: Language not supported
- common/lib/protocol-definitions/pnpm-lock.yaml: Language not supported
- pnpm-lock.yaml: Language not supported
- server/gitrest/pnpm-lock.yaml: Language not supported
- server/historian/pnpm-lock.yaml: Language not supported
- tools/benchmark/pnpm-lock.yaml: Language not supported
- tools/getkeys/pnpm-lock.yaml: Language not supported
- tools/test-tools/pnpm-lock.yaml: Language not supported
Comment on lines
+94
to
+95
| "@octokit/core": "^7.0.4", | ||
| "@octokit/rest": "^22.0.0", |
There was a problem hiding this comment.
Major version updates for @octokit/core (5→7) and @octokit/rest (21→22) may introduce breaking changes. Consider reviewing the changelog and ensuring compatibility with existing usage patterns in the codebase.
Suggested change
| "@octokit/core": "^7.0.4", | |
| "@octokit/rest": "^22.0.0", | |
| "@octokit/core": "^5.0.0", | |
| "@octokit/rest": "^21.0.0", |
jason-ha
approved these changes
Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
pnpm dedupe in all packages.
This can almost be done with:
pnpm exec flub exec "pnpm dedupe --ignore-scripts" --releaseGroupRoot=all --packagesThe "server" release group had several issues (see #25559) so it has been reverted to be handled seperatly.
Also updates @octokit/core and @octokit/rest to the latest versions to fix a compile error that happened after dedupe.
Reviewer Guidance
The review process is outlined on this wiki page.